trivialfis commented on issue #4953:
URL: https://github.com/apache/incubator-tvm/issues/4953#issuecomment-618640842


   @hcho3 One last request, otherwise I'm running out of ideas.
   
   Patch both xgboot and rabit's C API macro:
   
   For xgboost:
   
   ``` patch
   diff --git a/include/xgboost/c_api.h b/include/xgboost/c_api.h
   index f9c0a0ff..baaaeb43 100644
   --- a/include/xgboost/c_api.h
   +++ b/include/xgboost/c_api.h
   @@ -20,7 +20,7 @@
    #if defined(_MSC_VER) || defined(_WIN32)
    #define XGB_DLL XGB_EXTERN_C __declspec(dllexport)
    #else
   -#define XGB_DLL XGB_EXTERN_C
   +#define XGB_DLL XGB_EXTERN_C __attribute__ ((visibility ("default")))
    #endif  // defined(_MSC_VER) || defined(_WIN32)
    
    // manually define unsigned long
   ```
   
   For rabit:
   ``` patch
   diff --git a/include/rabit/c_api.h b/include/rabit/c_api.h
   index 0a96ef7..47c5735 100644
   --- a/include/rabit/c_api.h
   +++ b/include/rabit/c_api.h
   @@ -18,7 +18,7 @@
    #if defined(_MSC_VER) || defined(_WIN32)
    #define RABIT_DLL RABIT_EXTERN_C __declspec(dllexport)
    #else
   -#define RABIT_DLL RABIT_EXTERN_C
   +#define RABIT_DLL RABIT_EXTERN_C __attribute__ ((visibility ("default")))
    #endif  // defined(_MSC_VER) || defined(_WIN32)
    
    /*! \brief rabit unsigned long type */
   ```
   
   Build XGBoost with following flags appended:
   ```
   -DCMAKE_CXX_FLAGS='-fvisibility=hidden' -DCMAKE_C_FLAGS='-fvisibility=hidden'
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to