mbaret commented on pull request #5409:

   It looks like the refactor to AnnotatedRegionSet has broken this 'fix'. I 
think the important property to maintain is that 'every node should belong to a 
region' rather than 'every node should be annotated'. By this, I mean that the 
following structure:
    op -- const
   while not explicitly annotating every node, should imply that the const is 
still in a region, just not as an input or output. If we put a begin before the 
const, that implies there's a data flow path into the region through the 
constant, which isn't strictly true. Maybe this would require a slightly 
modified traversal in AnnotatedRegionSet to handle this case.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

Reply via email to