[GitHub] [incubator-tvm] jroesch commented on a change in pull request #5423: [RUNTIME][OBJECT] Introduce static slots for common objects.

[GitBox]

jroesch commented on a change in pull request #5423:
URL: https://github.com/apache/incubator-tvm/pull/5423#discussion_r414733387



##########
File path: include/tvm/ir/expr.h
##########
@@ -161,7 +163,8 @@ class RelayExprNode : public BaseExprNode {
   template<typename TTypeNode>
   inline const TTypeNode* type_as() const;
 
-  static constexpr const char* _type_key = "relay.Expr";
+  static constexpr const char* _type_key = "RelayExpr";

Review comment:
       I'm not sure I like this change, its better to have the keys name spaced 
to Relay imo.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org