Menooker commented on a change in pull request #5357:
URL: https://github.com/apache/incubator-tvm/pull/5357#discussion_r415207561



##########
File path: src/relay/transforms/fold_scale_axis.cc
##########
@@ -39,6 +39,10 @@ namespace relay {
  *
  * Use namespace to reduce potential naming conflict.
  */
+
+extern Expr MakeReshape(Expr data,
+                 Array<Integer> newshape);

Review comment:
       Would you plz suggest a `.h` where we can move this declaration to? The 
function is defined in `relay/transform.cc`. But it is not declared anywhere in 
a header file.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to