FrozenGene commented on a change in pull request #5452:
URL: https://github.com/apache/incubator-tvm/pull/5452#discussion_r415679526
##########
File path: python/tvm/relay/frontend/tflite.py
##########
@@ -1770,6 +1775,12 @@ def convert_pool2d(self, op, pool_type):
assert self.has_same_qnn_params(input_tensor, output_tensor), \
"qnn.op.max_pool2d requires input and output qnn
params to be same"
out = _op.nn.max_pool2d(in_expr, **params)
+ elif pool_type == "l2":
+ # l2_pool_2d is equivalent to sqrt(avg_pool(sqr(in_data)))
Review comment:
Better name `sqrt` to `square_root`, `sqr` to `square`. `sqrt` is too
similar with `sqr` so that code readers confuse easily.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
