u99127 commented on a change in pull request #5417:
URL: https://github.com/apache/incubator-tvm/pull/5417#discussion_r413829506
##########
File path: python/tvm/autotvm/measure/local_executor.py
##########
@@ -145,6 +145,7 @@ def submit(self, func, *args, **kwargs):
if not self.do_fork:
return LocalFutureNoFork(func(*args, **kwargs))
+ # TODO why they choose a queue size of 2? add a comment
Review comment:
Why is this 2 ?
##########
File path: python/tvm/micro/device/arm/stm32f746xx.py
##########
@@ -36,23 +55,41 @@ def create_micro_lib(obj_path, src_path, lib_type,
options=None):
options : Optional[List[str]]
additional options to pass to GCC
+
+ lib_src_paths : Optional[List[str]]
+ TODO
"""
if options is None:
options = []
+ else:
+ options = list(options)
+
options += [
- "-mcpu=cortex-m7",
- "-mlittle-endian",
- "-mfloat-abi=hard",
- "-mfpu=fpv5-sp-d16",
- "-mthumb",
- "-gdwarf-5",
+ # TODO(weberlo): make a debug flag
+ '-O2',
+ '-march=armv7e-m',
Review comment:
This is superfluous. -mcpu is a specific manifestation of -march for a
particular implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
