kevinthesun commented on a change in pull request #4312:
URL: https://github.com/apache/incubator-tvm/pull/4312#discussion_r416214792



##########
File path: python/tvm/relay/op/transform.py
##########
@@ -613,13 +613,13 @@ def strided_slice(data, begin, end, strides=None):
     data : relay.Expr
         The source array to be sliced.
 
-    begin: list of int
+    begin: relay.Expr

Review comment:
       Should we allow begin, end and strides to be list/tuple as well? And do 
conversion to const before calling backend API.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to