roastduck commented on pull request #5465: URL: https://github.com/apache/incubator-tvm/pull/5465#issuecomment-621282600
> Given that it is a quit fundamental construct that can leads to concise generated code(e.g. ? in CUDA), I think we should keep it throughout the lowering process by default. We can still merge the pass if it is an optional utility I agree. I will make it default. > If the goal is mainly to utilize LoopParition, perhaps a better way would be to insert likely into the condition and enable LoopPartition to deal with if_then_else. I think we are unable to insert `likely` automatically, because we don't know whether the condition is likely or unlikely, so `likely` must be written by users. Besides, what do you think about the cascading if_then_else issue above? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
