icemelon9 commented on a change in pull request #5357:
URL: https://github.com/apache/incubator-tvm/pull/5357#discussion_r417472667
##########
File path: python/tvm/relay/op/strategy/x86.py
##########
@@ -84,8 +88,13 @@ def conv2d_strategy_cpu(attrs, inputs, out_type, target):
raise ValueError("dilation should be positive value")
if groups == 1:
- if layout == "NCHW":
- assert kernel_layout == "OIHW"
+ if layout.startswith("NCHW"):
Review comment:
No, inside `_alter_conv2d_layout`, the `conv2d` layout should still be
NCHW, and this function will then convert layout into NCHWc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
