tqchen commented on a change in pull request #5491:
URL: https://github.com/apache/incubator-tvm/pull/5491#discussion_r418268635
##########
File path: include/tvm/runtime/data_type.h
##########
@@ -211,6 +215,13 @@ class DataType {
static DataType Handle(int bits = 64, int lanes = 1) {
return DataType(kHandle, bits, lanes);
}
+ /*!
+ * \brief Construct a None type.
+ * \return The constructed data type.
+ */
+ static DataType None() {
Review comment:
It would be great to have a single VoidType, so
GetType(DataType::Void()) better returns VoidType() and
GetRuntimeType(VoidType()) returns the DataType variant.
The main reason of the additional return is that we suppose to add an
WARNING if the check does not pass, see also the relations between runtime type
and type in
https://github.com/apache/incubator-tvm/blob/master/include/tvm/ir/type.h#L29
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
