jroesch commented on a change in pull request #5467:
URL: https://github.com/apache/incubator-tvm/pull/5467#discussion_r418270872
##########
File path: src/relay/op/memory/memory.cc
##########
@@ -360,12 +360,26 @@ bool ShapeFuncRel(const Array<Type>& types, int
num_inputs, const Attrs& attrs,
auto tuple = TupleType(func_type->arg_types);
auto in_types = FlattenTupleType(tuple);
auto out_types = FlattenTupleType(func_type->ret_type);
+ int num_types = 0;
Review comment:
Can you use the `FlattenTupleType` helper instead of manually processing
them like this? this won't work for nesting and is pretty close to the same
tuple processing code written everywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
