areusch commented on a change in pull request #5484:
URL: https://github.com/apache/incubator-tvm/pull/5484#discussion_r419685397
##########
File path: python/tvm/contrib/cc.py
##########
@@ -90,7 +90,8 @@ def get_target_triple():
def cross_compiler(compile_func,
options=None,
output_format=None,
- get_target_triple=None):
+ get_target_triple=None,
+ add_files=None):
Review comment:
okay, I think de-coupling the APIs in A1 makes sense. if we do that
though, then only autotvm (and other user scripts and any µTVM veneers) need to
care about linker flags and linker scripts, correct? we can remove that
complexity from `export_library`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
