kevinthesun commented on a change in pull request #5459:
URL: https://github.com/apache/incubator-tvm/pull/5459#discussion_r419829632
##########
File path: include/tvm/relay/attrs/algorithm.h
##########
@@ -50,14 +50,14 @@ struct ArgsortAttrs : public tvm::AttrsNode<ArgsortAttrs> {
};
struct TopKAttrs : public tvm::AttrsNode<TopKAttrs> {
- int k;
+ Expr k;
Review comment:
Agree this is just a temp solution before we can unify symbolic args
with attrs. Conceptually we don't need attrs to include these inputs any more,
no matter they are actually constant or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
