u99127 commented on a change in pull request #5486:
URL: https://github.com/apache/incubator-tvm/pull/5486#discussion_r420269543
##########
File path: python/tvm/relay/frontend/tflite.py
##########
@@ -109,16 +109,17 @@ def __init__(self, model, subgraph, exp_tab):
'PAD': self.convert_pad,
'POW': self.convert_pow,
'PRELU': self.convert_prelu,
- 'REDUCE_ANY': self._convert_reduce_any,
- 'REDUCE_MAX': self._convert_reduce_max,
- 'REDUCE_MIN': self._convert_reduce_min,
- 'REDUCE_PROD': self._convert_reduce_prod,
+ 'REDUCE_ANY': self.convert_reduce_any,
+ 'REDUCE_MAX': self.convert_reduce_max,
+ 'REDUCE_MIN': self.convert_reduce_min,
+ 'REDUCE_PROD': self.convert_reduce_prod,
'RELU':self.convert_relu,
Review comment:
In an ideal world that would be a separate PR rather than merging it in
here as that could just go in separately and pretty mechanically.
However, that's really not our development practice yet.
Ramana
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
