u99127 commented on a change in pull request #5516:
URL: https://github.com/apache/incubator-tvm/pull/5516#discussion_r420394839
##########
File path: src/support/ring_buffer.h
##########
@@ -63,19 +67,27 @@ class RingBuffer {
size_t ncopy = head_ptr_ + bytes_available_ - old_size;
memcpy(&ring_[0] + old_size, &ring_[0], ncopy);
}
- } else if (ring_.size() > n * 8 && ring_.size() > kInitCapacity &&
bytes_available_ > 0) {
- // shrink too large temporary buffer to avoid out of memory on some
embedded devices
+ } else if (ring_.size() > n * 8 &&
+ ring_.size() > kInitCapacity) {
+ // shrink too large temporary buffer to
+ // avoid out of memory on some embedded devices
+ if (bytes_avaliable_ != 0) {
Review comment:
bytes_available ?
##########
File path: src/support/ring_buffer.h
##########
@@ -63,19 +67,27 @@ class RingBuffer {
size_t ncopy = head_ptr_ + bytes_available_ - old_size;
memcpy(&ring_[0] + old_size, &ring_[0], ncopy);
}
- } else if (ring_.size() > n * 8 && ring_.size() > kInitCapacity &&
bytes_available_ > 0) {
- // shrink too large temporary buffer to avoid out of memory on some
embedded devices
+ } else if (ring_.size() > n * 8 &&
+ ring_.size() > kInitCapacity) {
+ // shrink too large temporary buffer to
+ // avoid out of memory on some embedded devices
+ if (bytes_avaliable_ != 0) {
+ // move existing bytes to the head.
size_t old_bytes = bytes_available_;
-
std::vector<char> tmp(old_bytes);
-
Read(&tmp[0], old_bytes);
- ring_.resize(kInitCapacity);
- ring_.shrink_to_fit();
memcpy(&ring_[0], &tmp[0], old_bytes);
- head_ptr_ = 0;
bytes_available_ = old_bytes;
+ }
+ // shrink the ring.
+ size_t new_size = kInitCapacity;
+ new_size = std::max(new_size, n);
+ new_size = std::max(new_size, byte_available_);
Review comment:
bytes_available ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
