u99127 commented on pull request #5528:
URL: https://github.com/apache/incubator-tvm/pull/5528#issuecomment-624679105
>
>
> > Have you seen #5519 ?
> > Ramana
>
> Just now. I replied there.
Yours goes further than #5519 and I'll think through it a bit more. My
initial reaction is that this looks ok but there is one aspect that we could
pull in here from 5519 :
There is an appeal to keeping the number of inputs and outputs in the table
and passing the input and output tensors to the helper functions seems to be
high. It also seemed to me that the equality check could be done at the top
level and any place where we had a range check we punted to the helper function
as I had commented. I'll try and push out something the approach for something
like conv2d.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
