kparzysz-quic commented on a change in pull request #5533:
URL: https://github.com/apache/incubator-tvm/pull/5533#discussion_r421140419
##########
File path: include/tvm/arith/analyzer.h
##########
@@ -107,6 +107,7 @@ class ConstIntBound : public ObjectRef {
*/
class ConstIntBoundAnalyzer {
public:
+ using BoundMapType = std::unordered_map<ObjectPtr<const PrimExprNode>,
ConstIntBound, ObjectHash>;
Review comment:
Using `PrimExpr` worked fine. I tried `ObjectRef` before, but it failed
(I guess I missed the ObjectHash/Equal for refs), and I went the way of
`ObjectPtr`. This really makes all the remaining changes unnecessary
(although I think the default return type of `GetObjectPtr` may be useful).
What do you suggest I do with the rest of the changes? Should I remove the
`ObjectPtr<const>` completely?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
