tqchen commented on a change in pull request #5506:
URL: https://github.com/apache/incubator-tvm/pull/5506#discussion_r421558689
##########
File path: python/tvm/contrib/emcc.py
##########
@@ -44,25 +42,25 @@ def create_js(output,
The compile string.
"""
cmd = [cc]
- cmd += ["-Oz"]
- if not side_module:
- cmd += ["-s", "RESERVED_FUNCTION_POINTERS=2"]
- cmd += ["-s", "NO_EXIT_RUNTIME=1"]
- extra_methods = ['cwrap', 'getValue', 'setValue', 'addFunction']
- cfg = "[" + (','.join("\'%s\'" % x for x in extra_methods)) + "]"
- cmd += ["-s", "EXTRA_EXPORTED_RUNTIME_METHODS=" + cfg]
- else:
- cmd += ["-s", "SIDE_MODULE=1"]
- cmd += ["-o", output]
+ cmd += ["-O3"]
+
+ cmd += ["-std=c++14"]
+ cmd += ["-s", "ERROR_ON_UNDEFINED_SYMBOLS=0"]
+ cmd += ["-s", "STANDALONE_WASM=1"]
+
Review comment:
We can certainly enable memory growth
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
