jroesch commented on pull request #5526: URL: https://github.com/apache/incubator-tvm/pull/5526#issuecomment-625568446
I addressed all the feedback except a few things that don't work like changing to `get_mut_ptr()` which doesn't work due to the array being borrowed and not mutably borrowed. Looking into that DLCode I think having a from instance is not very safe given the lifetime of the DLTensor is not tied to the lifetime of the NDArray in anyway. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org