tmoreau89 commented on a change in pull request #5544:
URL: https://github.com/apache/incubator-tvm/pull/5544#discussion_r422274176
##########
File path: src/runtime/rpc/rpc_session.h
##########
@@ -189,6 +197,98 @@ class RPCSession {
*/
virtual bool IsLocalSession() const = 0;
+ // Asynchrous variant of API
+ // These APIs are used by the RPC server to allow sessions that
+ // have special implementations for the async functions.
+ //
+ // In the async APIs, an exception is returned by the passing
+ // async_error=true, encode_args=[error_msg].
+
+ /*!
+ * \brief Whether the session is async.
+ *
+ * If the session is not async, its Aync implementations
+ * simply calls into the their synchronize counterparts,
+ * and the callback is guaranteed to be called before the async function
finishes.
+ *
+ * \return the async state.
+ *
+ * \note We can only use async session in an Event driven RPC server.
+ */
+ virtual bool IsAsync() const;
+
+ /*!
+ * \brief Asynchrously call func.
+ * \param func The function handle.
+ * \param arg_values The argument values.
+ * \param arg_type_codes the type codes of the argument.
+ * \param num_args Number of arguments.
+ *
+ * \param callback The callback to pass the return value or exception.
+ */
+ virtual void AsyncCallFunc(PackedFuncHandle func,
+ const TVMValue* arg_values,
+ const int* arg_type_codes,
+ int num_args,
+ FAsyncCallback callback);
+
+ /*!
+ * \brief Asynchrous version of CopyToRemote.
+ *
+ * \param local_from The source host data.
+ * \param local_from_offset The byte offeset in the from.
+ * \param remote_to The target array.
+ * \param remote_to_offset The byte offset in the to.
+ * \param nbytes The size of the memory in bytes.
+ * \param remote_ctx_to The target context.
+ * \param type_hint Hint of content data type.
+ *
+ * \param on_complete The callback to signal copy complete.
+ * \note All the allocated memory in local_from, and remote_to
+ * must stay alive until on_compelete is called.
+ */
+ virtual void AsyncCopyToRemote(void* local_from,
+ size_t local_from_offset,
+ void* remote_to,
+ size_t remote_to_offset,
+ size_t nbytes,
+ TVMContext remote_ctx_to,
+ DLDataType type_hint,
+ FAsyncCallback on_complete);
+
+ /*!
+ * \brief Asynchrous version of CopyFromRemote.
+ *
+ * \param local_from The source host data.
Review comment:
order of comments does not match params order
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
