zhiics commented on a change in pull request #5501:
URL: https://github.com/apache/incubator-tvm/pull/5501#discussion_r422515250
##########
File path: src/te/schedule/schedule_dataflow_rewrite.cc
##########
@@ -418,7 +418,7 @@ Array<Tensor> CacheWriteWithReLayoutTensor(Schedule sch,
}
Operation cache_op = TensorComputeOpNode::make(
- tensor_op->name + "." + scope, tensor_op->tag, new_axis,
+ (String)((std::string)tensor_op->name + "." + scope), tensor_op->tag,
new_axis,
Review comment:
Shouldn't we be able to directly constructor a String object from
std::string or const char*?
https://github.com/apache/incubator-tvm/blob/f939c61805e77f1f63ec44676c4e936a94055908/include/tvm/runtime/container.h#L368-L375
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
