ANSHUMAN87 commented on pull request #5236:
URL: https://github.com/apache/incubator-tvm/pull/5236#issuecomment-626208924
@tqchen : Thank you very much for your enlightening response!
I will definitely work towards attaining similar code standard as per
existing runtimes in TVM.
Please bear with me, if i misunderstood some of your comments. I have some
queries to those as below:
1. **Folder structure:** You are right it has no significance. It is just a
personal choice to me in organizing the files. The reference(mldotnet) you have
suggested also follow similar organization of files.
But if you think otherwise is more suitable, we can keep all the source
codes in one place or maintain Managed & Unmanaged separation similar to JVM
runtime(Core & Native).
2. **Naming Convention:** Do you suggest the name change from
UnmanagedRuntimeWrapper --> UnmanagedRuntime as an example ?
3. **Layers of abstractions:** You are right there is a very thin line
boundary between Managed & Unmanaged space. Unmanaged space does not store any
memory of its own in most of the cases, it is just an enabler or interface into
TVM runtime. If you can provide one specific example which one you want to
remove from Unmanged space, may be that might help me understand your comment
more clearly.
4. **Package Release:** I am not sure how to release package elsewhere and
pertain to same PR. Can you please help me do it? May be some reference would
be helpful.
Please help me clarify above queries.
Thank again!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
