kevinthesun commented on a change in pull request #5429:
URL: https://github.com/apache/incubator-tvm/pull/5429#discussion_r422534560
##########
File path: python/tvm/relay/op/_transform.py
##########
@@ -189,10 +192,9 @@ def _reshape_shape_func(data_shape, newshape, ndim):
out[infer_idx] = old_size // new_size
return out
-@_reg.register_shape_func("reshape", False)
+@_reg.register_shape_func("reshape", True)
Review comment:
In the short term, is it possible that we just check reshape in fuse to
identify constant newshape case? In the future, maybe we would like to have a
more systematic to way set fuse pattern regarding the dynamism of op inputs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
