areusch commented on a change in pull request #5590:
URL: https://github.com/apache/incubator-tvm/pull/5590#discussion_r424707211
##########
File path: python/tvm/contrib/binutil.py
##########
@@ -166,6 +166,11 @@ def tvm_callback_get_section_size(binary_path,
section_name, toolchain_prefix):
# NOTE: in the past, section_size has been wrong on x86. it may be
# inconsistent. TODO: maybe stop relying on `*size` to give us the size and
# instead read the section with `*objcopy` and count the bytes.
+ # NOTE(areusch): I think the problem is due to alignment ops in the linker.
+ # Since this is going away in the impending switch to on-device runtime,
+ # add a constant to hopefully absorb these relocations.
+ if section_size > 0:
+ section_size += 32
Review comment:
removed that if block, though I haven't tested riscv at all at master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
