hlu1 commented on a change in pull request #5622:
URL: https://github.com/apache/incubator-tvm/pull/5622#discussion_r427669686
##########
File path: src/relay/analysis/util.cc
##########
@@ -338,13 +338,13 @@ bool IsNDArrayAllGreaterEqual(const runtime::NDArray&
tensor, T value) {
return true;
}
-// Cache the operators that are checked recursively to reduce lookup overhead.
-static const auto& expand_dims_op = Op::Get("expand_dims");
-static const auto& reshape_op = Op::Get("reshape");
-static const auto& transpose_op = Op::Get("transpose");
-static const auto& squeeze_op = Op::Get("squeeze");
-
bool IsAllPositiveConstant(const Expr& expr) {
+ // Cache the operators that are checked recursively to reduce lookup
overhead.
+ static const auto& expand_dims_op = Op::Get("expand_dims");
+ static const auto& reshape_op = Op::Get("reshape");
+ static const auto& transpose_op = Op::Get("transpose");
+ static const auto& squeeze_op = Op::Get("squeeze");
+
Review comment:
Change these static ops from non-local to local static objects as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
