comaniac commented on a change in pull request #5627:
URL: https://github.com/apache/incubator-tvm/pull/5627#discussion_r428246339
##########
File path: python/tvm/relay/dataflow_pattern/__init__.py
##########
@@ -112,21 +112,23 @@ def match(self, expr: Expr) -> bool:
"""
return match(self, expr)
- def partition(self, expr: Expr) -> bool:
+ def partition(self, expr: Expr, attrs=None) -> Expr:
"""
Parition the expression into functions defined by this pattern
Parameters
----------
expr : tvm.relay.Expr
The expression to match.
+ attrs : dict[str->Object]
Review comment:
Just carious. Is this also a valid type format in Python 3.6+? Cuz I
only know `Dict[str, Object]` in this case.
Also since this could also be None, it should be `Optional[Dict[str,
Object]]` or `dict[str->Object] or None` I guess?
##########
File path: python/tvm/relay/dataflow_pattern/__init__.py
##########
@@ -572,10 +574,12 @@ def partition(pattern: DFPattern, expr: Expr) -> Expr:
The pattern to match
expr : tvm.relay.Expr
The expression to split into functions
+ expr : dict[str->Object]
Review comment:
ditto.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
