comaniac edited a comment on issue #5662: URL: https://github.com/apache/incubator-tvm/issues/5662#issuecomment-632996700
Thanks for the advise! This major difference affects how the constant values will be used in the runtime, and I consider Relay functions should be used as same as Relay ops. For example, we may have ``` %0 = nn.conv2d(%data, meta[relay.Constant][0]; ``` If we treat `nn.conv2d` as a Relay function, we can see that even one if its arguments is a constant, we still maintain its function signature and pass the constant node via the call. Since this concept is applicable to fused and composite functions, I think it would be better for pattern language to have the same behavior. Meanwhile, I would like to ask @tqchen @zhiics @yzhliu for double confirm :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
