Menooker edited a comment on pull request #5601: URL: https://github.com/apache/incubator-tvm/pull/5601#issuecomment-633214226
@tqchen I have changed the legalization pass to pure TIR->TIR. Added a pass called `BF16Lowering` to replace bf16 type with uint16 and lower the casting by shifting. I have met a problem that I need to replace `BufferNode` of bf16 with uint16. It works well and can produce same result of numpy. However, a lowered bf16 cast cannot pass `assert_structural_equal` test, like [here](https://github.com/Menooker/incubator-tvm/blob/177f99a8ce7f95e927cabeaf18684ade0c8ebc73/tests/python/unittest/test_tir_transform_bf16_legalize.py#L143). Is this a problem of this PR? I have checked the string output, the lowered TIR strings are the same. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
