mbrookhart commented on a change in pull request #5676:
URL: https://github.com/apache/incubator-tvm/pull/5676#discussion_r431244615
##########
File path: docs/langref/relay_pattern.rst
##########
@@ -28,17 +28,34 @@ Such a language is not just useful for building a rewriter
but also providing ex
In the backend world, we could use the same machinery to build a higher level
API using bring your own code generation. This API takes set of patterns
describing your hardware capabilities and an external compiler, providing a
relatively smooth heterogeneous experience out of the box.
-Examples
-========
+Pattern Examples
+================
-There are quite a few properties that are worth matching of operators below we
examine how to match tree properties, and expand on some use cases that are not
fully explored in the prototype. The first example is a simple case where we
want to match one operator with a single input OR another operator with a
single input, see the below diagram for a graphical representation and
corresponding code::
+There are quite a few properties that are worth matching of operators below we
examine how to match tree properties, and expand on some use cases that are not
fully explored in the prototype. This section
Review comment:
"There are quite a few properties of operators that are worth matching.
Below we examine..."
##########
File path: docs/langref/relay_pattern.rst
##########
@@ -139,3 +237,125 @@ Domination
**********
Match child pattern, find a match for the parent pattern, insuring that the
child ultimately dominates the parrent (i.e., no nodes outside the pattern use
outputs of the parent), and that ever node betwen the child and the pattern
matches the path pattern.
+
+Applications
+============
+
+The pattern language provides not only the pattern matching but also pattern
processing. The later
Review comment:
"The Pattern Language provides pattern processing in addition to
matching capabilities. Here we introduce two
pattern processing approaches and provide some examples."
I don't think the middle sentence is necessary because you go into much
greater detail below on the two approaches?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
