kevinthesun commented on a change in pull request #5684:
URL: https://github.com/apache/incubator-tvm/pull/5684#discussion_r431502771
##########
File path: topi/python/topi/bifrost/conv2d.py
##########
@@ -142,13 +142,14 @@ def _schedule_spatial_pack(cfg, s, output, conv,
data_vec, kernel_vec):
s[data_vec].unroll(vw)
if isinstance(kernel_vec.op, tvm.te.ComputeOp) and kernel_vec.name ==
'kernel_vec':
+ co, ci, kh, kw, vc = s[kernel_vec].op.axis
Review comment:
Looks like this part share the logic with arm_cpu and mali. We can move
this into [conv2d_nchw_spatial_pack
compute](https://github.com/apache/incubator-tvm/blob/master/topi/python/topi/arm_cpu/conv2d_spatial_pack.py#L27).
An example is in x86 conv2d:
https://github.com/apache/incubator-tvm/blob/master/topi/python/topi/x86/conv2d.py#L188-L201
With this method, we can fix mali/arm_cpu/bifrost in one shot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
