comaniac edited a comment on pull request #5689: URL: https://github.com/apache/incubator-tvm/pull/5689#issuecomment-635637903
> Thanks for the PR so soon! Is there an example of how partition works on a constant match? In particular, does the constant remain propagated into the body? An example can be found in the unit test: https://github.com/apache/incubator-tvm/pull/5689/files#diff-f9920485e5e341787129348ce1985db9R213 Also, could you provide an example to show your expection of constant propogation? I've checked that all merge composite unit tests are passed with the current implement even for the DNNL codegen unit tests that use composite functions with parameter binding. It would be better if you could include all your use cases in the unit tests so that we could on the same page. > > On a general point, it's helpful if reformats are kept separate from feature additions for reviews so it's easy to see what the changes are. Yeah the bugfix should be put to a separate PR for sure. For re-formatting, I didn't intentionally reformat the unit test file. VSCode by default auto-formats the file once I paste some code. I was even considering to revert auto-formatting due to the reason you pointed out. However, I checked the re-formatting and it is mostly just blank and too-long lines, so I think it should be fine for this small feature PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
