comaniac commented on a change in pull request #5693:
URL: https://github.com/apache/incubator-tvm/pull/5693#discussion_r432604623
##########
File path: src/relay/ir/dataflow_matcher.cc
##########
@@ -613,6 +613,25 @@ class PatternGrouper {
CHECK_EQ(groups_[gid_].gid, gid_);
}
+ bool EmbedConst(const Expr& expr, const DFPattern pattern) {
Review comment:
Maybe provide function description to explain the constant embedding
rules?
##########
File path: python/tvm/relay/dataflow_pattern/__init__.py
##########
@@ -318,15 +318,14 @@ class VarPattern(DFPattern):
Parameters
----------
name_hint: str
- The name of the variable.
- This name only acts as a hint, and is not used
- for equality.
+ The name of the variable. Optional, if not provided,
+ the pattern will match any VarNode
Review comment:
period.
##########
File path: docs/langref/relay_pattern.rst
##########
@@ -266,10 +266,10 @@ Attribute Pattern
Check that the operator matched by the pattern has an attribute with a
particular value.
-Input
-*****
+Variable Pattern
+****************
-Check that the expression is an input, i.e has no parents and is a variable.
+Check that the expression is a relay Variable, and optional provide a name to
match to the Variable name
Review comment:
period.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
