junrushao1994 commented on a change in pull request #5687:
URL: https://github.com/apache/incubator-tvm/pull/5687#discussion_r434092013



##########
File path: include/tvm/node/container.h
##########
@@ -49,11 +50,24 @@ using runtime::ObjectRef;
 using runtime::String;
 using runtime::StringObj;
 
+struct MapObjectHash {

Review comment:
       One thing i am not sure of: `ObjectHash` and `ObjectEqual` are defined 
in object.h, do we really want to make it depend on classes defined in 
`container.h`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to