kevinthesun commented on a change in pull request #4312: URL: https://github.com/apache/incubator-tvm/pull/4312#discussion_r434115162
########## File path: python/tvm/relay/frontend/tensorflow.py ########## @@ -614,6 +614,53 @@ def _impl(inputs, attr, params, mod): return out return _impl +def _nms(): + def _impl(inputs, attr, params, mod): + # Get parameter values + max_output_size = int(np.atleast_1d(inputs[2].data.asnumpy().astype("int64"))[0]) Review comment: Handle symbolic max_output_size: ```suggestion try: max_output_size = int(np.atleast_1d(inputs[2].data.asnumpy().astype("int64"))[0]) except Exception: try: max_output_size = _infer_value(inputs[2], params, mod).asnumpy().astype("int64").tolist()[0] except Exception: max_output_size = -1 ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org