Menooker commented on a change in pull request #5601:
URL: https://github.com/apache/incubator-tvm/pull/5601#discussion_r434955653
##########
File path: python/tvm/_ffi/runtime_ctypes.py
##########
@@ -58,7 +58,8 @@ class DataType(ctypes.Structure):
0 : 'int',
1 : 'uint',
2 : 'float',
- 4 : 'handle'
+ 4 : 'handle',
+ 65: 'bfloat'
Review comment:
May I ask what I am supposed to do here? In the newest commit, I changed
`4 : 'handle'` here to 3, and let 4 mapped to bfloat. I also changed `class
TypeCode(object):` and relavent C++ class to let `NULL` mapped to 21, instead
of 4. I have noticed that in `class TypeCode(object):`, we have to define both
`BFLOAT` and `NULL`, so I thought we needed to resolve the conflict as they
were all mapped to 4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
