comaniac commented on a change in pull request #5756:
URL: https://github.com/apache/incubator-tvm/pull/5756#discussion_r438263324
##########
File path: python/tvm/relay/expr.py
##########
@@ -487,6 +487,8 @@ def const(value, dtype=None):
- bool maps to "bool"
- other using the same default rule as numpy.
"""
+ if dtype == 'float': # for numpy, float is float64, for us it is float32
+ dtype = 'float32'
Review comment:
Let's just leave it here for now, as we may need to change the behavior
of this function according to TQ's comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
