masahi commented on pull request #5779: URL: https://github.com/apache/incubator-tvm/pull/5779#issuecomment-643469350
> The user-supplied(!) names are the part before the (last, ha, here only) `.` and they're stable. Do you mean Torch allows users to set the argument name? If you also know when exactly Torch changes input names, then sure I can see passing another names for TVM would be annoying. But I'd argue that most users are not familiar with such details of Torchscript, so we shouldn't expect them to correctly deal with names chosen by Torch. Requiring input names are common across other framework. I think making it optional makes API a bit confusing, while benefiting only users who are intimately familiar with Torchscript internals. Making the API as close as possible to other frontends also applies to input shapes, so I don't want to make it optional, either. Shapes are required because Relay assumes static input shapes. So my opinion is not make `input_shapes` optional, to keep the API straightforward/less confusing, and close to other frontends. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
