tqchen commented on a change in pull request #5788:
URL: https://github.com/apache/incubator-tvm/pull/5788#discussion_r439850074
##########
File path: src/arith/rewrite_simplify.cc
##########
@@ -123,7 +123,7 @@ PrimExpr RewriteSimplifier::Impl::VisitExpr_(const AddNode*
op) {
// Pattern var to match any expression
PVar<PrimExpr> x, y, z, b1, b2, s1, s2;
// Pattern var match IntImm
- PVar<IntImm> c1, c2, c3;
+ PVarOpt<Optional<IntImm>> c1, c2, c3;
Review comment:
I don't think either approaches are good here. Let us leave it as it is
for now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
