ANSHUMAN87 commented on a change in pull request #5816:
URL: https://github.com/apache/incubator-tvm/pull/5816#discussion_r440324179
##########
File path: tests/python/unittest/test_target_custom_datatypes.py
##########
@@ -128,7 +128,7 @@ def test_bfloat_add_and_cast_FloatImm():
Z = topi.cast(
topi.add(
topi.cast(X, dtype="custom[bfloat]16"),
- tvm.tir.FloatImm("custom[bfloat]16", 1.5)),
+ tvm.tir.FloatImm("float", 1.5)),
Review comment:
I am sorry, i did not understand completely the logic behind it. I mean
how FloatImm can support datatype other than float. It looks like some
potential hole. That is why i added check. Anyway if it is on purpose, then i
will ignore it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
