FrozenGene commented on a change in pull request #5753:
URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r441938545
##########
File path: python/tvm/runtime/module.py
##########
@@ -41,6 +41,10 @@ def __init__(self, handle):
self.handle = handle
self._entry = None
self.entry_name = "__tvm_main__"
+ # TODO:(FrozenGene): support rpc
+ if self.type_key == 'GraphRuntimeFactory':
+ #from tvm.runtime.graph_runtime_factory import
GraphRuntimeFactoryModule
+ self._entry = self.runtime_create
Review comment:
As we are in rpc said, we want to select multi models in one shared
library. If we just support `default`, it doesn't our purpose? If we don't want
to change the module, maybe we could use auto type key wrapper in the rfc? That
is to say when we call `tvm.runtime.load_module`, we will check the type key,
if we are `GraphRuntimeFactory`, we go to `GraphRuntimeFactoryModule` directly
and we could do everything inside it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
