zhanghaohit commented on pull request #5842: URL: https://github.com/apache/incubator-tvm/pull/5842#issuecomment-647009494
> Thanks @zhanghaohit for the contribution! I've taken a quick pass but will need to make a more thorough pass next. > > I believe it's important to check two things: > (1) that the new ISA changes won't break the current Pynq tests and binary. We'll need to update the bitstreams to make sure that it can work out of the box on the new ISA. > (2) we would want to prepare some setup instructions for this Altera OpenCL variant of VTA to run end to end tests. Something like this: https://docs.tvm.ai/vta/install.html, which @liangfu for instance added instructions for Intel SoC FPGAs Thanks @tmoreau89 for the comments. (1) I've back-tested the Pynq tests. It works. The only thing we have to do is to re-compile the bitstream to make it compatible with the new ISA. Yes. We have to update the bitstreams in the repo. (2) Sorry that we forgot the document for the OpenCL VTA installation. We'll update the docs accordingly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
