tqchen edited a comment on pull request #5883:
URL: https://github.com/apache/incubator-tvm/pull/5883#issuecomment-647588304
This PR is good to get a global context. Some further comments: To make sure
we get the a thoroughly review and smooth upstream, let us break this PR down
further into several PRs, it also helps us to logically organize and think
about the overall design architecture:
- Changes outside ansor, consider use one PR for each group of change(e.g.
rewrite simplify change can be its own PR).
- A single PR for the state data structures, loop_state.h, loop_state.py
- Clearly document all the fields, key functions
- Discuss the implication of the design, by briefly comment on the search
process in loop_state.h
- A PR contains Measurements related code for ansor
- Specific implementation of each ansor primitives(TransformStep), each as
its own PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
