mbaret commented on a change in pull request #5885:
URL: https://github.com/apache/incubator-tvm/pull/5885#discussion_r443704576



##########
File path: src/target/source/source_module.cc
##########
@@ -119,7 +122,6 @@ class CSourceModuleNode : public runtime::ModuleNode {
       return PackedFunc(
           [sptr_to_self, this](TVMArgs args, TVMRetValue* rv) { *rv = 
this->const_vars_; });
     } else {
-      LOG(FATAL) << "Unknown packed function: " << name;

Review comment:
       I think that would be neater. Even a 1 line PR would be fine.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to