tqchen commented on a change in pull request #5918:
URL: https://github.com/apache/incubator-tvm/pull/5918#discussion_r445178372
##########
File path: src/runtime/threading_backend.cc
##########
@@ -159,14 +159,8 @@ class ThreadGroup::Impl {
CPU_SET(sorted_order_[sorted_order_.size() - i - 1], &cpuset);
}
} else {
- int big_count = big_count_;
- // Imagine our x86 has cores 0 - 7
- // physical cores are 0 - 3, logical cores are 4 - 7, big_count_ is 8
- // we wish we run on physical cores, not logical cores to avoid
contention issue.
Review comment:
We need to look into the code. Perhaps do num_binds =
std::min(MaxConcurrency(), big_count_); to keep backward compact for BIG.LITTLE
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
