trevor-m commented on a change in pull request #5857:
URL: https://github.com/apache/incubator-tvm/pull/5857#discussion_r445798573
##########
File path: tests/python/relay/test_op_level5.py
##########
@@ -270,8 +270,8 @@ def verify_get_valid_counts(dshape, score_threshold,
id_index, score_index):
intrp = relay.create_executor("debug", ctx=ctx, target=target)
out = intrp.evaluate(func)(np_data)
tvm.testing.assert_allclose(out[0].asnumpy(), np_out1, rtol=1e-3,
atol=1e-04)
- # get_valid_count for cuda doesn't do data rearrangement
- if target == 'cuda':
+ # get_valid_count for cuda, opencl doesn't do data rearrangement
+ if target in ['cuda', 'opencl']:
return
Review comment:
OpenCL uses the same implementation as CUDA. The CUDA implementation of
`get_valid_counts` was changed to no longer rearrange the output of
`get_valid_counts` because it will be rearranged by NMS later anyway. This
gives the correct output for NMS. See
https://github.com/apache/incubator-tvm/pull/5339
That issue with NMS looks to be a separate issue where the CUDA
implementation wasn't fully updated to match changes to CPU implementation by
https://github.com/apache/incubator-tvm/pull/4312/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
