giuseros edited a comment on pull request #5925: URL: https://github.com/apache/incubator-tvm/pull/5925#issuecomment-651082114
Hi @tqchen , I followed the same approach for the other conv2ds. I added a `test_conv2d_nhwc` in the `test_topi_conv2d_int8.py`. This would have caught the typo we are discussing, and I was able also to fix another small typo in `conv2d_gemm.py` (which had to do with wrong TIR operator precedence). Please, let me know what do you think. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
