MarisaKirisame commented on a change in pull request #5941:
URL: https://github.com/apache/incubator-tvm/pull/5941#discussion_r447318960



##########
File path: src/relay/op/tensor/transform.cc
##########
@@ -1713,6 +1713,54 @@ RELAY_REGISTER_OP("collapse_sum_like")
     .set_attr<FTVMCompute>("FTVMCompute", CollapseSumLikeCompute)
     .set_attr<TOpPattern>("TOpPattern", kCommReduce);
 
+// CollapseSumTo: <A, B> -> B where CollapseSumTo(A, B) = B

Review comment:
       BroadCast is a symmetric function that take two tensor type A, B, and 
return the broadcast type (I am confusing the type and term level a bit.). I am 
just listing constraint between the two elements with the equation after where.
   what constraint does it exist between two argument of CollapseSumTo? If I 
get it I can 'collapse' A into B, which mean the type B can be broadcast to A 
right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to