mbrookhart commented on a change in pull request #5826:
URL: https://github.com/apache/incubator-tvm/pull/5826#discussion_r448039240
##########
File path: python/tvm/relay/op/_tensor_grad.py
##########
@@ -511,7 +511,7 @@ def batch_matmul_grad(orig, grad):
@register_gradient("reshape")
def reshape_grad(orig, grad):
"""Gradient of reshape"""
- return [reshape_like(grad, orig.args[0]), orig.args[1]]
+ return [reshape_like(grad, orig.args[0])]
Review comment:
The numerical approx_grad doesn't seem to work for this case, and it
doesn't seem the dynamic version was tested before. I need to look at the
autodiff infrastructure more closely, perhaps this should be a second PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
