jcf94 commented on pull request #5962: URL: https://github.com/apache/incubator-tvm/pull/5962#issuecomment-653291178
> Left a lot of feedback, overall would like to get some clarity in the docs and comments, and think about reducing away some of the concepts to better map to existing TVM systems, it seems like some of the configuration and other bits might be able to fit in nicely with the new machinery from the UnifiedIR. The PR is long and I started to get tired towards the end so I will try to come back for a secondary pass. > > Thanks for all your hardwork on this! Thanks! Your review comments are really helpful! I agree that the original intention of our LoopState system is similar to the UnifiedIR to some extent. We also had some periodic discussions with @Hzfengsy during the development. Since the UnifiedIR is not ready for now, we kept the current design, it's great if we can upgrade Ansor with UnifiedIR in the future. cc @merrymercy ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
