ANSHUMAN87 commented on a change in pull request #5753:
URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r449634321
##########
File path: python/tvm/rpc/client.py
##########
@@ -160,7 +160,12 @@ def load_module(self, path):
m : Module
The remote module containing remote function.
"""
- return _ffi_api.LoadRemoteModule(self._sess, path)
+ module = _ffi_api.LoadRemoteModule(self._sess, path)
+ type_key = self.get_function("runtime.ModuleGetTypeKey")(module)
+ if type_key == "GraphRuntimeFactory":
+ from tvm.runtime.graph_runtime_factory import
GraphRuntimeFactoryModule
+ return GraphRuntimeFactoryModule(module)
Review comment:
Thanks! I totally agree with you :)
It is just that in usual practice any sort of Factory the Naming follows
convention of XXXFactory. But here it is little different.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
